-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-6088] Correct how tasks that get remote results are shown in UI. #4839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0a19b2f to
84d617c
Compare
|
Test build #28136 has finished for PR 4839 at commit
|
|
Test build #28141 has finished for PR 4839 at commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PS I noticed when using TaskInfo recently that it has gettingResult and finished property that does this same check. I used them instead of also comparing the times to 0.
|
I'm not familiar enough with the UI code, but one more problem I have noticed is that when the task is in the getting results stage, the UI shows the time as execution time and only after the task finishes do you see the getting results time. Is it possible to update the time waiting for results to be fetched while the task is in progress ? |
|
No it was based on the old code. Didn't get a chance to run this on the cluster yet. |
|
Test build #28155 has finished for PR 4839 at commit
|
|
Functionality-wise this looks good to me. |
|
Although I think this missed 1.3, as far as I'm concerned you can merge it into |
|
LGTM I'm merging this into master 1.3 thanks |
It would be great to fix this for 1.3. since the fix is surgical and it helps understandability for users. cc shivaram pwendell Author: Kay Ousterhout <[email protected]> Closes #4839 from kayousterhout/SPARK-6088 and squashes the following commits: 3ab012c [Kay Ousterhout] Update getting result time incrementally, correctly set GET_RESULT status f346b49 [Kay Ousterhout] Typos 748ea6b [Kay Ousterhout] Fixed build failure 84d617c [Kay Ousterhout] [SPARK-6088] Correct how tasks that get remote results are shown in the UI. (cherry picked from commit 6948ab6) Signed-off-by: Andrew Or <[email protected]>
It would be great to fix this for 1.3. since the fix is surgical and it helps understandability for users.
cc @shivaram @pwendell