[SPARK-4411][UI]Add kill link for jobs in the UI #4823

lianhuiwang · 2015-02-28T03:28:26Z

We should have a "kill" link for each job, similar to what we have for each stage, so it's easier for users to kill jobs in the UI. @kayousterhout can you take a look at this? thanks.

SparkQA · 2015-02-28T03:32:41Z

Test build #28107 has started for PR 4823 at commit af461cc.

This patch merges cleanly.

SparkQA · 2015-02-28T04:52:03Z

Test build #28107 has finished for PR 4823 at commit af461cc.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-02-28T04:52:07Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28107/
Test PASSed.

SparkQA · 2015-02-28T05:28:07Z

Test build #28112 has started for PR 4823 at commit 7f52874.

This patch merges cleanly.

SparkQA · 2015-02-28T06:48:17Z

Test build #28112 has finished for PR 4823 at commit 7f52874.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-02-28T06:48:22Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28112/
Test PASSed.

srowen · 2015-02-28T15:21:32Z

core/src/main/scala/org/apache/spark/ui/jobs/AllJobsPage.scala

Just a few tiny comments to consider, if you have to otherwise make changes to this PR: this might be easier to read with string interpolation

SparkQA · 2015-03-01T06:32:40Z

Test build #28140 has started for PR 4823 at commit 584240a.

This patch merges cleanly.

lianhuiwang · 2015-03-01T06:47:37Z

@srowen i have update for your comments. can you take a look again. thanks.

SparkQA · 2015-03-01T06:48:04Z

Test build #28142 has started for PR 4823 at commit 25fc0fd.

This patch merges cleanly.

SparkQA · 2015-03-01T07:32:15Z

Test build #28140 has finished for PR 4823 at commit 584240a.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-03-01T07:32:19Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28140/
Test FAILed.

SparkQA · 2015-03-01T08:09:56Z

Test build #28142 has finished for PR 4823 at commit 25fc0fd.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-03-01T08:10:01Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/28142/
Test PASSed.

srowen · 2015-03-01T09:01:22Z

OK by me; would be good to let @kayousterhout give it a thumbs up.

andrewor14 · 2015-03-24T03:06:35Z

@JoshRosen @kayousterhout what do you think

andrewor14 · 2015-03-24T03:06:54Z

core/src/main/scala/org/apache/spark/ui/jobs/StagesTab.scala

please add : Unit return type here (and other places)

SparkQA · 2015-03-24T07:33:16Z

Test build #29064 has started for PR 4823 at commit ba16839.

This patch does not merge cleanly.

SparkQA · 2015-03-24T09:18:10Z

Test build #29064 has finished for PR 4823 at commit ba16839.

This patch passes all tests.
This patch does not merge cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-03-24T09:18:13Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29064/
Test PASSed.

SparkQA · 2015-03-25T01:53:22Z

Test build #29135 has started for PR 4823 at commit a0eee0c.

This patch does not merge cleanly.

SparkQA · 2015-03-25T03:16:12Z

Test build #29135 has finished for PR 4823 at commit a0eee0c.

This patch fails Spark unit tests.
This patch does not merge cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-03-25T03:16:17Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/29135/
Test FAILed.

srowen · 2015-06-16T20:19:05Z

I think this would have to be rebased at least, and rewritten to match the new kill link behavior elsewhere. Can this be closed?

…iwang

…iwang

## What changes were proposed in this pull request? Currently users can kill stages via the web ui but not jobs directly (jobs are killed if one of their stages is). I've added the ability to kill jobs via the web ui. This code change is based on apache#4823 by lianhuiwang and updated to work with the latest code matching how stages are currently killed. In general I've copied the kill stage code warning and note comments and all. I also updated applicable tests and documentation. ## How was this patch tested? Manually tested and dev/run-tests ![screen shot 2016-10-11 at 4 49 43 pm](https://cloud.githubusercontent.com/assets/13952758/19292857/12f1b7c0-8fd4-11e6-8982-210249f7b697.png) Author: Alex Bozarth <[email protected]> Author: Lianhui Wang <[email protected]> Closes apache#15441 from ajbozarth/spark4411.

Add kill link for jobs in the UI

af461cc

Update JobsTab.scala

7f52874

srowen reviewed Feb 28, 2015
View reviewed changes

lianhuiwang added 2 commits March 1, 2015 14:26

Merge branch 'master' of https://github.com/apache/spark into SPARK-4411

7a6143a

address srowen’s comments

584240a

address srowen’s comments

25fc0fd

andrewor14 reviewed Mar 24, 2015
View reviewed changes

core/src/main/scala/org/apache/spark/ui/jobs/StagesTab.scala Outdated

Copy link

Contributor

andrewor14 Mar 24, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add : Unit return type here (and other places)

add : Unit return type

ba16839

add an else case

a0eee0c

lianhuiwang closed this Jun 17, 2015

ajbozarth added a commit to ajbozarth/spark that referenced this pull request Oct 11, 2016

add kill jobs link. initial commit based on pr apache#4823 by @lianhu…

d0e2083

…iwang

ajbozarth mentioned this pull request Oct 12, 2016

[SPARK-4411] [Web UI] Add "kill" link for jobs in the UI #15441

Closed

[SPARK-4411][UI]Add kill link for jobs in the UI #4823

[SPARK-4411][UI]Add kill link for jobs in the UI #4823

Uh oh!

Conversation

lianhuiwang commented Feb 28, 2015

Uh oh!

SparkQA commented Feb 28, 2015

Uh oh!

SparkQA commented Feb 28, 2015

Uh oh!

AmplabJenkins commented Feb 28, 2015

Uh oh!

SparkQA commented Feb 28, 2015

Uh oh!

SparkQA commented Feb 28, 2015

Uh oh!

AmplabJenkins commented Feb 28, 2015

Uh oh!

srowen Feb 28, 2015

Choose a reason for hiding this comment

Uh oh!

SparkQA commented Mar 1, 2015

Uh oh!

lianhuiwang commented Mar 1, 2015

Uh oh!

SparkQA commented Mar 1, 2015

Uh oh!

SparkQA commented Mar 1, 2015

Uh oh!

AmplabJenkins commented Mar 1, 2015

Uh oh!

SparkQA commented Mar 1, 2015

Uh oh!

AmplabJenkins commented Mar 1, 2015

Uh oh!

srowen commented Mar 1, 2015

Uh oh!

andrewor14 commented Mar 24, 2015

Uh oh!

andrewor14 Mar 24, 2015

Choose a reason for hiding this comment

Uh oh!

SparkQA commented Mar 24, 2015

Uh oh!

SparkQA commented Mar 24, 2015

Uh oh!

AmplabJenkins commented Mar 24, 2015

Uh oh!

SparkQA commented Mar 25, 2015

Uh oh!

SparkQA commented Mar 25, 2015

Uh oh!

AmplabJenkins commented Mar 25, 2015

Uh oh!

srowen commented Jun 16, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants