[SPARK-46535][SQL][3.4] Fix NPE when describe extended a column without col stats #48160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@MaxGekk @yaooqinn @LuciferYang @guykhazma , this is a backport to 3.4 for #44524 can u please review this |
MaxGekk
reviewed
Sep 19, 2024
Member
MaxGekk
left a comment
MaxGekk
left a comment
There was a problem hiding this comment.
@saitharun15 Please, enable GAs in your fork.
LuciferYang
reviewed
Sep 19, 2024
| import org.apache.spark.sql.types.StringType | ||
| import org.apache.spark.util.Utils | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
please remove this empty line.
Author
|
@MaxGekk I have enabled GAs in my fork |
dongjoon-hyun
approved these changes
Sep 19, 2024
Member
There was a problem hiding this comment.
+1, LGTM. Thank you, @saitharun15 , @LuciferYang , @MaxGekk .
Although @saitharun15 needs to setup his fork more properly, we can see that SQL module tests passed in the CIs.
For Scala linter, I verified manually.
$ dev/scalastyle
Using SPARK_LOCAL_IP=localhost
Scalastyle checks passed.
Merged to branch-3.4 for Apache Spark 3.4.4.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Sep 19, 2024
…ut col stats ### What changes were proposed in this pull request? Backport [#44524 ] to 3.4 for [[SPARK-46535]](https://issues.apache.org/jira/browse/SPARK-46535)[SQL] Fix NPE when describe extended a column without col stats ### Why are the changes needed? Currently executing DESCRIBE TABLE EXTENDED a column without col stats with v2 table will throw a null pointer exception. ``` Cannot invoke "org.apache.spark.sql.connector.read.colstats.ColumnStatistics.min()" because the return value of "scala.Option.get()" is null java.lang.NullPointerException: Cannot invoke "org.apache.spark.sql.connector.read.colstats.ColumnStatistics.min()" because the return value of "scala.Option.get()" is null at org.apache.spark.sql.execution.datasources.v2.DescribeColumnExec.run(DescribeColumnExec.scala:63) at org.apache.spark.sql.execution.datasources.v2.V2CommandExec.result$lzycompute(V2CommandExec.scala:43) at org.apache.spark.sql.execution.datasources.v2.V2CommandExec.result(V2CommandExec.scala:43) at org.apache.spark.sql.execution.datasources.v2.V2CommandExec.executeCollect(V2CommandExec.scala:49) at org.apache.spark.sql.execution.QueryExecution$$anonfun$eagerlyExecuteCommands$1.$anonfun$applyOrElse$1(QueryExecution.scala:98) at org.apache.spark.sql.execution.SQLExecution$.$anonfun$withNewExecutionId$6(SQLExecution.scala:118) at org.apache.spark.sql.execution.SQLExecution$.withSQLConfPropagated(SQLExecution.scala:195) at org.apache.spark.sql.execution.SQLExecution$.$anonfun$withNewExecutionId$1(SQLExecution.scala:103) ``` ### Does this PR introduce _any_ user-facing change? ### How was this patch tested? Add a new test describe extended (formatted) a column without col stats ### Was this patch authored or co-authored using generative AI tooling? No Closes #48160 from saitharun15/SPARK-46535-branch-3.4. Lead-authored-by: saitharun15 <[email protected]> Co-authored-by: Sai Tharun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Backport [#44524 ] to 3.4 for [SPARK-46535][SQL] Fix NPE when describe extended a column without col stats
Why are the changes needed?
Currently executing DESCRIBE TABLE EXTENDED a column without col stats with v2 table will throw a null pointer exception.
Does this PR introduce any user-facing change?
How was this patch tested?
Add a new test describe extended (formatted) a column without col stats
Was this patch authored or co-authored using generative AI tooling?
No