[SPARK-49347][R][FOLLOW-UP] Set SPARK_TESTING in Windows build #47881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itholic
approved these changes
Aug 27, 2024
Member
Author
|
Merged to master. |
Member
Author
|
Yeah I noticed it. I'll fix it next week |
Member
Author
|
Made a followup at #47972 |
HyukjinKwon
added a commit
that referenced
this pull request
Sep 3, 2024
…arkR deprecation warning ### What changes were proposed in this pull request? This PR proposes to have the dedicated environment variable called `SPARKR_SUPPRESS_DEPRECATION_WARNING` to skip SparkR deprecation warning. ### Why are the changes needed? In order to recover SparkR build on Windows (https://github.com/apache/spark/actions/workflows/build_sparkr_window.yml). Previously we did not set `SPARK_TESTING` before. #47881 set it and the build it broken. This PR works around it by having a dedicated environment variable. ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? Manually tested. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #47972 from HyukjinKwon/SPARK-49347-followup2. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a followup of #47842 that sets
SPARK_TESTINGin Windows build.Why are the changes needed?
The PR added a deprecation warning, and that fails Windows build. It should set
SPARK_TESTINGto work around the warning in the build (https://github.com/apache/spark/actions/runs/10563932730/job/29265243035).Does this PR introduce any user-facing change?
No, test-only.
How was this patch tested?
Will monitor the job after this PR is merged.
Was this patch authored or co-authored using generative AI tooling?
No