Skip to content

[SPARK-5751] [SQL] Sets SPARK_HOME as SPARK_PID_DIR when running Thrift server test suites #4758

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
liancheng wants to merge 2 commits into from
Closed

[SPARK-5751] [SQL] Sets SPARK_HOME as SPARK_PID_DIR when running Thrift server test suites #4758

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b3d1e3
Sets SPARK_HOME as SPARK_PID_DIR when running Thrift server test suites
liancheng Feb 25, 2015
252fa0f
Uses temporary directory as Thrift server PID directory
liancheng Feb 27, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions ...erver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -315,7 +315,14 @@ abstract class HiveThriftServer2Test extends FunSuite with BeforeAndAfterAll wit

logInfo(s"Trying to start HiveThriftServer2: port=$port, mode=$mode, attempt=$attempt")

logPath = Process(command, None, "SPARK_TESTING" -> "0").lines.collectFirst {
val env = Seq(
// Disables SPARK_TESTING to exclude log4j.properties in test directories.
"SPARK_TESTING" -> "0",
// Points SPARK_PID_DIR to SPARK_HOME, otherwise only 1 Thrift server instance can be started
// at a time, which is not Jenkins friendly.
"SPARK_PID_DIR" -> "../../")
Copy link
Contributor

@chenghao-intel chenghao-intel Feb 25, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am wondering a better path would be Utils.createTempDir(..), just in case we want to run the test suite simultaneously in the local machine as well.

Copy link
Contributor Author

@liancheng liancheng Feb 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point.

Copy link
Contributor

@andrewor14 andrewor14 Feb 26, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually, can we just use sys.props(java.io.tmpdir) instead of creating a new directory?

Copy link
Contributor

@chenghao-intel chenghao-intel Feb 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a different directory for each run, otherwise the PID file will be overwritten when multiple jenkins unit tests run parallel.

Copy link
Contributor

@andrewor14 andrewor14 Feb 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh you're right. Looks like we currently set it to /tmp already, which is probably what java.io.tmpdir is anyway in most cases


logPath = Process(command, None, env: _*).lines.collectFirst {
case line if line.contains(LOG_FILE_MARK) => new File(line.drop(LOG_FILE_MARK.length))
}.getOrElse {
throw new RuntimeException("Failed to find HiveThriftServer2 log file.")
Expand Down Expand Up @@ -346,7 +353,7 @@ abstract class HiveThriftServer2Test extends FunSuite with BeforeAndAfterAll wit

private def stopThriftServer(): Unit = {
// The `spark-daemon.sh' script uses kill, which is not synchronous, have to wait for a while.
Process(stopScript, None).run().exitValue()
Process(stopScript, None, "SPARK_PID_DIR" -> "../../").run().exitValue()
Thread.sleep(3.seconds.toMillis)

warehousePath.delete()
Expand Down