Skip to content

[SPARK-48975][PROTOBUF] Remove unnecessary ScalaReflectionLock definition from protobuf #47459

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LuciferYang wants to merge 1 commit into from
+0 −1
Closed

[SPARK-48975][PROTOBUF] Remove unnecessary ScalaReflectionLock definition from protobuf #47459

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion connector/protobuf/src/main/scala/org/apache/spark/sql/protobuf/package.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,5 +17,4 @@
package org.apache.spark.sql

package object protobuf {
Copy link
Contributor Author

@LuciferYang LuciferYang Jul 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are other empty package object definitions within the Spark internal code, such as

spark/streaming/src/main/scala/org/apache/spark/streaming/dstream/package.scala

Lines 18 to 24 in 285489b

package org.apache.spark.streaming
/**
* Various implementations of DStream's.
* @see [[org.apache.spark.streaming.dstream.DStream]]
*/
package object dstream

and

spark/core/src/main/scala/org/apache/spark/util/random/package.scala

Lines 18 to 23 in 285489b

package org.apache.spark.util
/**
* Utilities for random number generation.
*/
package object random

Therefore, in this PR, only the definition of ·ScalaReflectionLock· was removed while the package object protobuf was retained.

protected[protobuf] object ScalaReflectionLock
}