Skip to content

Conversation

@wForget
Copy link
Member

@wForget wForget commented Jul 19, 2024

Backports #47410 to 3.5

What changes were proposed in this pull request?

  • Promote spark.sql.legacy.chunkBase64String.enabled from a legacy/internal config to a regular/public one.
  • Add test cases for unbase64

Why are the changes needed?

Keep the same behavior as before. More details: #47303 (comment)

Does this PR introduce any user-facing change?

yes, revert behavior change introduced in #47303

How was this patch tested?

existing unit test

Was this patch authored or co-authored using generative AI tooling?

No

…ng.enabled from a legacy/internal config to a regular/public one

### What changes were proposed in this pull request?

+ Promote spark.sql.legacy.chunkBase64String.enabled from a legacy/internal config to a regular/public one.
+ Add test cases for unbase64

### Why are the changes needed?

Keep the same behavior as before. More details: apache#47303 (comment)

### Does this PR introduce _any_ user-facing change?

yes, revert behavior change introduced in apache#47303

### How was this patch tested?

existing unit test

### Was this patch authored or co-authored using generative AI tooling?

No

Closes apache#47410 from wForget/SPARK-47307_followup.

Lead-authored-by: wforget <[email protected]>
Co-authored-by: Kent Yao <[email protected]>
Signed-off-by: Kent Yao <[email protected]>

(cherry picked from commit af5eb08)
@yaooqinn
Copy link
Member

cc @cloud-fan

yaooqinn pushed a commit that referenced this pull request Jul 20, 2024
…4String.enabled from a legacy/internal config to a regular/public one

Backports #47410 to 3.5

### What changes were proposed in this pull request?

+ Promote spark.sql.legacy.chunkBase64String.enabled from a legacy/internal config to a regular/public one.
+ Add test cases for unbase64

### Why are the changes needed?

Keep the same behavior as before. More details: #47303 (comment)

### Does this PR introduce _any_ user-facing change?

yes, revert behavior change introduced in #47303

### How was this patch tested?

existing unit test

### Was this patch authored or co-authored using generative AI tooling?

No

Closes #47416 from wForget/SPARK-47307_followup_3.5.

Authored-by: wforget <[email protected]>
Signed-off-by: Kent Yao <[email protected]>
@yaooqinn
Copy link
Member

merged to branch-3.5. Thank you @wForget @LuciferYang @dongjoon-hyun

@yaooqinn yaooqinn closed this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants