Skip to content

Conversation

@HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This jar was added in #42069 but moved in #43735.

Why are the changes needed?

To clean up a jar not used.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Existing tests should check

Was this patch authored or co-authored using generative AI tooling?

No.

@HyukjinKwon HyukjinKwon changed the title [MINOR][TESTS} Remove unused test jar (udf_noA.jar) [MINOR][TESTS] Remove unused test jar (udf_noA.jar) Jul 11, 2024
@HyukjinKwon
Copy link
Member Author

@grundprinzip would you mind taking a look and trying to merge this PR :-)?

@grundprinzip
Copy link
Contributor

Merging

@grundprinzip grundprinzip merged commit b560e4e into apache:master Jul 12, 2024
HyukjinKwon added a commit that referenced this pull request Jul 12, 2024
HyukjinKwon added a commit to HyukjinKwon/spark that referenced this pull request Jul 12, 2024
@HyukjinKwon
Copy link
Member Author

Oops, sorry I told him wrongly about merging a PR. I reverted and opened a new PR: #47315

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Jul 16, 2024

😄 Ya, this is the 7th instance.

Given that the last one was last year, this is an annual event.

Do you think we need to prevent this kind of mistake by updating our committer docs or changing the following rule, @HyukjinKwon and @grundprinzip ?

spark/.asf.yaml

Lines 30 to 33 in 3923d7f

enabled_merge_buttons:
merge: false
squash: true
rebase: true

@grundprinzip
Copy link
Contributor

Conceptually yes, but I wanted to spend some time understanding the delta between the merge button and the script and how GH might have changed in between. One idea would be to use a GH action for the script as well that triggers by a keyword for example so that one does not always need to push directly from a local machine.

@HyukjinKwon
Copy link
Member Author

Yeah I think we should block it merge button

jingz-db pushed a commit to jingz-db/spark that referenced this pull request Jul 22, 2024
jingz-db pushed a commit to jingz-db/spark that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants