-
Notifications
You must be signed in to change notification settings - Fork 29k
[MINOR][TESTS] Remove unused test jar (udf_noA.jar) #47309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@grundprinzip would you mind taking a look and trying to merge this PR :-)? |
|
Merging |
This reverts commit b560e4e.
This reverts commit 0e940e2.
|
Oops, sorry I told him wrongly about merging a PR. I reverted and opened a new PR: #47315 |
|
😄 Ya, this is the 7th instance. Given that the last one was last year, this is an annual event. Do you think we need to prevent this kind of mistake by updating our committer docs or changing the following rule, @HyukjinKwon and @grundprinzip ? Lines 30 to 33 in 3923d7f
|
|
Conceptually yes, but I wanted to spend some time understanding the delta between the merge button and the script and how GH might have changed in between. One idea would be to use a GH action for the script as well that triggers by a keyword for example so that one does not always need to push directly from a local machine. |
|
Yeah I think we should block it merge button |
This reverts commit b560e4e.
What changes were proposed in this pull request?
This jar was added in #42069 but moved in #43735.
Why are the changes needed?
To clean up a jar not used.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing tests should check
Was this patch authored or co-authored using generative AI tooling?
No.