[SPARK-48840][INFRA] Remove unnecessary existence check for ./dev/free_disk_space_container
#47263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @zhengruifeng FYI |
zhengruifeng
approved these changes
Jul 9, 2024
panbingkun
approved these changes
Jul 9, 2024
Contributor
|
merged to master |
Contributor
Author
|
Thanks @zhengruifeng @panbingkun |
jingz-db
pushed a commit
to jingz-db/spark
that referenced
this pull request
Jul 22, 2024
…ee_disk_space_container` ### What changes were proposed in this pull request? This PR removed the check for the existence of `./dev/free_disk_space_container` before execution, because `./dev/free_disk_space_container` has already been backported to branch-3.4 and branch-3.5 through apache#45624 and apache#43381, so there is no need to check its existence before execution. ### Why are the changes needed? Remove unnecessary existence check for `./dev/free_disk_space_container`. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Pass GitHub Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#47263 from LuciferYang/SPARK-48840. Authored-by: yangjie01 <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR removed the check for the existence of
./dev/free_disk_space_containerbefore execution, because./dev/free_disk_space_containerhas already been backported to branch-3.4 and branch-3.5 through #45624 and #43381, so there is no need to check its existence before execution.Why are the changes needed?
Remove unnecessary existence check for
./dev/free_disk_space_container.Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions
Was this patch authored or co-authored using generative AI tooling?
No