[SPARK-48774][SQL] Use SparkSession in SQLImplicits #47173
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yaooqinn
approved these changes
Jul 2, 2024
zhengruifeng
approved these changes
Jul 2, 2024
HyukjinKwon
changed the title
Member
|
What do you think about this one? #45727 (comment) |
Member
Author
|
I think we can add a new API, and deprecate old ones |
Member
To clarify, SPARK-46575 applies to 4.0, so it can be changed directly. |
Member
Author
|
API seems from 3.5.2 #45727? I think it's safer to just deprecate and add a new one in 4.0 |
Member
Member
Author
|
We could add. What I am not sure is that this is matched with exiting API |
HyukjinKwon
force-pushed
the
minor-implicit-session
branch
from
f761b39 to
84cb6f5
Compare
Member
|
For STS SQLContext replacement, I opened #47176, let's discuss there. |
Member
Author
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to use
SparkSessionatSQLImplicits.Why are the changes needed?
To use
SparkSsessionthat is encouraged overSQLContext.Does this PR introduce any user-facing change?
No.
How was this patch tested?
CI in this PR should test them out.
Was this patch authored or co-authored using generative AI tooling?
No.