[SPARK-48268][CORE] Add a configuration for SparkContext.setCheckpointDir #46571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mridulm
reviewed
May 14, 2024
Co-authored-by: Mridul Muralidharan <[email protected]>
hvanhovell
approved these changes
May 14, 2024
HyukjinKwon
changed the title
core/src/main/scala/org/apache/spark/internal/config/package.scala
Outdated
Show resolved
Hide resolved
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
I'm wondering about the corner case. What happens when the users have different values for this configuration and SparkContext.setCheckpointDir. It can happen during the migration as a type of human mistakes.
- I guess
SparkContext.setCheckpointDirwill override this configuration. If then, please write the precedence in the config documentation. - Also, I'm wondering if we want to show a proper warning or even to raise exceptions because this is a critical mistake.
xinrong-meng
approved these changes
May 15, 2024
Member
Author
This one, I think it's fine. We already have similar configurations such as |
mridulm
reviewed
May 16, 2024
zhengruifeng
approved these changes
May 16, 2024
mridulm
approved these changes
May 16, 2024
Contributor
mridulm
left a comment
mridulm
left a comment
There was a problem hiding this comment.
Just a minor comment on wording. The code change itself looks good to me.
core/src/main/scala/org/apache/spark/internal/config/package.scala
Outdated
Show resolved
Hide resolved
Member
Author
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR adds
spark.checkpoint.dirconfiguration so users can set the checkpoint dir when they submit their application.Why are the changes needed?
Separate the configuration logic so the same app can run with a different checkpoint.
In addition, this would be useful for Spark Connect with #46570.
Does this PR introduce any user-facing change?
Yes, it adds a new user-facing configuration.
How was this patch tested?
unittest added
Was this patch authored or co-authored using generative AI tooling?
No.