Skip to content

[SPARK-48241][SQL] CSV parsing failure with char/varchar type columns #46537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
liujiayi771 wants to merge 2 commits into from
Closed

[SPARK-48241][SQL] CSV parsing failure with char/varchar type columns #46537

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d3378a2
SPARK-48241: CSV parsing failure with char/varchar type columns
liujiayi771 May 11, 2024
204a4ab
Address comments
liujiayi771 May 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/LogicalPlan.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,9 @@ abstract class LogicalPlan
def resolve(schema: StructType, resolver: Resolver): Seq[Attribute] = {
schema.map { field =>
resolve(field.name :: Nil, resolver).map {
case a: AttributeReference => a
case a: AttributeReference =>
// Keep the metadata in given schema.
a.copy(metadata = field.metadata)(exprId = a.exprId, qualifier = a.qualifier)

@ulysses-you ulysses-you May 11, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a.withMetadata(field.metadata)

case _ => throw QueryExecutionErrors.resolveCannotHandleNestedSchema(this)
}.getOrElse {
throw QueryCompilationErrors.cannotResolveAttributeError(
Expand Down
4 changes: 4 additions & 0 deletions sql/core/src/test/resources/test-data/char.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
color,name
pink,Bob
blue,Mike
grey,Tom
24 changes: 24 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/csv/CSVSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,6 +80,7 @@ abstract class CSVSuite
private val valueMalformedFile = "test-data/value-malformed.csv"
private val badAfterGoodFile = "test-data/bad_after_good.csv"
private val malformedRowFile = "test-data/malformedRow.csv"
private val charFile = "test-data/char.csv"

/** Verifies data and schema. */
private def verifyCars(
Expand Down Expand Up @@ -3342,6 +3343,29 @@ abstract class CSVSuite
expected)
}
}

test("SPARK-48241: CSV parsing failure with char/varchar type columns") {
withTable("charVarcharTable") {
spark.sql(
s"""
|CREATE TABLE charVarcharTable(
| color char(4),
| name varchar(10))
|USING csv
|OPTIONS (
| header "true",
| path "${testFile(charFile)}"
|)
""".stripMargin)
val expected = Seq(
Row("pink", "Bob"),
Row("blue", "Mike"),
Row("grey", "Tom"))
checkAnswer(
sql("SELECT * FROM charVarcharTable"),
expected)
}
}
}

class CSVv1Suite extends CSVSuite {
Expand Down