[SPARK-48131][CORE][FOLLOWUP] Add a new configuration for the MDC key of Task Name #46446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
To @mridulm , are you okay with the default value of |
dongjoon-hyun
approved these changes
May 8, 2024
Member
There was a problem hiding this comment.
I'm fine for both true or false of the default value.
Please determine the default according to @mridulm 's perspective because he is the effective user of MDC who will be affected by this change.
Member
|
To @mridulm , let me merge this first because @cloud-fan will cut Today. |
Member
|
Merged to master. Thank you, @gengliangwang ! |
Member
Author
|
Thanks a lot, @dongjoon-hyun ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Introduce a new Spark config
spark.log.legacyTaskNameMdc.enabled:When true, the MDC key
mdc.taskNamewill be set in the logs, which is consistent with the behavior of Spark 3.1 to Spark 3.5 releases. When false, the logging framework will usetask_nameas the MDC key for consistency with other new MDC keys.Why are the changes needed?
As discussed in #46386 (comment), we should add a configuration and migration guide about the change in the MDC key of Task Name.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Manual test
Was this patch authored or co-authored using generative AI tooling?
No