Skip to content

[SPARK-48107][PYTHON] Exclude tests from Python distribution #46354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nchammas wants to merge 1 commit into from
Closed

[SPARK-48107][PYTHON] Exclude tests from Python distribution #46354

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/MANIFEST.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

# Reference: https://setuptools.pypa.io/en/latest/userguide/miscellaneous.html

graft pyspark
recursive-include pyspark *.pyi py.typed *.json
Copy link
Contributor Author

@nchammas nchammas May 3, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HyukjinKwon - Instead of this, I prefer to exclude tests as follows:

$ diff python/MANIFEST-json.in python/MANIFEST-notests.in 
19c19
< recursive-include pyspark *.pyi py.typed *.json
---
> graft pyspark
31a32
> global-exclude **/tests/**

That way, if we add new files in the future that don't happen to match the glob expressions on this line they will still be picked up.

But I believe you prefer the approach taken here, so I've started with that.

recursive-include deps/jars *.jar
graft deps/bin
recursive-include deps/sbin spark-config.sh spark-daemon.sh start-history-server.sh stop-history-server.sh
Expand Down