Skip to content

Conversation

@HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR is a followup of #45053 that includes lib/py4j*zip in the package. Currently it's being picked up by https://github.com/apache/spark/blob/master/python/MANIFEST.in#L26. For other files, we don't create deps directory in setup.py for pyspark-connect so they are not included. But lib is being included.

Why are the changes needed?

To exclude unrelated files.

Does this PR introduce any user-facing change?

No, the main change has not been released out yet.

How was this patch tested?

Manually packaged, and checked the contents via vi.

Was this patch authored or co-authored using generative AI tooling?

No.

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants