[SPARK-46894][PYTHON][FOLLOW-UP] Includes error-conditions.json into PyPI package
#46328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @nchammas FYI |
Member
Author
|
and @itholic too |
dongjoon-hyun
approved these changes
May 2, 2024
nchammas
approved these changes
May 2, 2024
Contributor
nchammas
left a comment
nchammas
left a comment
There was a problem hiding this comment.
I'm surprised none of the tests I ran as part of #44920 caught this issue. I built several packages via make-distribution.sh and tested them successfully.
https://github.com/apache/spark/actions/runs/8913716987/job/24479781481 is broken for now.
I guess this CI build tests a non-standard install path that I didn't cover in my testing. Is it specific to spark-connect?
HyukjinKwon
force-pushed
the
SPARK-46894-followup
branch
from
5add375 to
9bc1d1a
Compare
Member
|
Oh, much simpler. |
dongjoon-hyun
approved these changes
May 2, 2024
Member
Author
|
Merged to master. It will be tested in the scheduled job. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a followup of #44920 that includes
error-conditions.jsoninto PyPI package.Why are the changes needed?
So PyPI packages work with pip install. https://github.com/apache/spark/actions/runs/8913716987/job/24479781481 is broken for now.
Does this PR introduce any user-facing change?
No, the main change has not been released out yet.
How was this patch tested?
Manually tested the packaging, and check the file exists in the package.
Was this patch authored or co-authored using generative AI tooling?
No.