Skip to content

[MINOR] Fix the grammar of some comments on renaming error classes #46321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nchammas wants to merge 1 commit into from
Closed

[MINOR] Fix the grammar of some comments on renaming error classes #46321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/utils/src/main/scala/org/apache/spark/SparkThrowableHelper.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ private[spark] object ErrorMessageFormat extends Enumeration {
private[spark] object SparkThrowableHelper {
val errorReader = new ErrorClassesJsonReader(
// Note that though we call them "error classes" here, the proper name is "error conditions",
// hence why the name of the JSON file different. We will address this inconsistency as part
// hence why the name of the JSON file is different. We will address this inconsistency as part
// of this ticket: https://issues.apache.org/jira/browse/SPARK-47429
Seq(SparkClassUtils.getSparkClassLoader.getResource("error/error-conditions.json")))

Expand Down
4 changes: 2 additions & 2 deletions connector/kafka-0-10-sql/src/main/scala/org/apache/spark/sql/kafka010/KafkaExceptions.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ private object KafkaExceptionsHelper {
val errorClassesJsonReader: ErrorClassesJsonReader =
new ErrorClassesJsonReader(
// Note that though we call them "error classes" here, the proper name is "error conditions",
// hence why the name of the JSON file different. We will address this inconsistency as part
// of this ticket: https://issues.apache.org/jira/browse/SPARK-47429
// hence why the name of the JSON file is different. We will address this inconsistency as
// part of this ticket: https://issues.apache.org/jira/browse/SPARK-47429
Seq(getClass.getClassLoader.getResource("error/kafka-error-conditions.json")))
}

Expand Down
2 changes: 1 addition & 1 deletion core/src/test/scala/org/apache/spark/SparkThrowableSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class SparkThrowableSuite extends SparkFunSuite {

private val errorJsonFilePath = getWorkspaceFilePath(
// Note that though we call them "error classes" here, the proper name is "error conditions",
// hence why the name of the JSON file different. We will address this inconsistency as part
// hence why the name of the JSON file is different. We will address this inconsistency as part
// of this ticket: https://issues.apache.org/jira/browse/SPARK-47429
"common", "utils", "src", "main", "resources", "error", "error-conditions.json")

Expand Down
2 changes: 1 addition & 1 deletion python/pyspark/errors/error_classes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
import importlib.resources

# Note: Though we call them "error classes" here, the proper name is "error conditions",
# hence why the name of the JSON file different.
# hence why the name of the JSON file is different.
# For more information, please see: https://issues.apache.org/jira/browse/SPARK-46810
# This discrepancy will be resolved as part of: https://issues.apache.org/jira/browse/SPARK-47429
ERROR_CLASSES_JSON = (
Expand Down