[SPARK-46632][SQL] Fix subexpression elimination when equivalent ternary expressions have different children #46135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fferent children throw IllegalStateException
zml1206
changed the title
Contributor
Author
peter-toth
reviewed
Apr 19, 2024
| checkShortcut(Not(And(equal, Literal(false))), 1) | ||
| } | ||
|
|
||
| test("Equivalent ternary expressions have different children") { |
Contributor
There was a problem hiding this comment.
Hmm, this is because ((1 + 2) + 3) semanticEquals to ((3 + 1) + 2) but their children are different. So when we compute the common elements between the above 2 here:
only ((1 + 2) + 3) remains in localEquivalenceMap but it's children don't. So later when we want to remove ((1 + 2) + 3) we can't find its children...
I think we could fix the above code that computes localEquivalenceMap, but the change in PR is simpler and doesn't seem to do any harm.
peter-toth
approved these changes
Apr 19, 2024
Contributor
Author
|
cc @cloud-fan Do you have time to help take a look? Thank you. |
Contributor
Author
|
@peter-toth Can this PR be merged? |
Contributor
|
good catch! merging to master/3.5! |
cloud-fan
pushed a commit
that referenced
this pull request
Aug 12, 2024
…ary expressions have different children
Remove unexpected exception thrown in `EquivalentExpressions.updateExprInMap()`. Equivalent expressions may contain different children, it should happen expression not in map and `useCount` is -1.
For example, before this PR will throw IllegalStateException
```
Seq((1, 2, 3), (2, 3, 4)).toDF("a", "b", "c")
.selectExpr("case when a + b + c>3 then 1 when c + a + b>0 then 2 else 0 end as d").show()
```
Bug fix.
No.
New unit test, before this PR will throw IllegalStateException: *** with use count: -1
No.
Closes #46135 from zml1206/SPARK-46632.
Authored-by: zml1206 <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
(cherry picked from commit 2fb8dff)
Signed-off-by: Wenchen Fan <[email protected]>
Contributor
Author
|
Thank you. @cloud-fan @peter-toth |
zml1206
added a commit
to zml1206/spark
that referenced
this pull request
May 7, 2025
…ary expressions have different children
Remove unexpected exception thrown in `EquivalentExpressions.updateExprInMap()`. Equivalent expressions may contain different children, it should happen expression not in map and `useCount` is -1.
For example, before this PR will throw IllegalStateException
```
Seq((1, 2, 3), (2, 3, 4)).toDF("a", "b", "c")
.selectExpr("case when a + b + c>3 then 1 when c + a + b>0 then 2 else 0 end as d").show()
```
Bug fix.
No.
New unit test, before this PR will throw IllegalStateException: *** with use count: -1
No.
Closes apache#46135 from zml1206/SPARK-46632.
Authored-by: zml1206 <[email protected]>
Signed-off-by: Wenchen Fan <[email protected]>
turboFei
pushed a commit
to turboFei/spark
that referenced
this pull request
Nov 6, 2025
…ary expressions have different children (apache#542) Remove unexpected exception thrown in `EquivalentExpressions.updateExprInMap()`. Equivalent expressions may contain different children, it should happen expression not in map and `useCount` is -1. For example, before this PR will throw IllegalStateException ``` Seq((1, 2, 3), (2, 3, 4)).toDF("a", "b", "c") .selectExpr("case when a + b + c>3 then 1 when c + a + b>0 then 2 else 0 end as d").show() ``` Bug fix. No. New unit test, before this PR will throw IllegalStateException: *** with use count: -1 No. Closes apache#46135 from zml1206/SPARK-46632. Authored-by: zml1206 <[email protected]> (cherry picked from commit 2fb8dff) Signed-off-by: Wenchen Fan <[email protected]> Co-authored-by: zml1206 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Remove unexpected exception thrown in
EquivalentExpressions.updateExprInMap(). Equivalent expressions may contain different children, it should happen expression not in map anduseCountis -1.For example, before this PR will throw IllegalStateException
Why are the changes needed?
Bug fix.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
New unit test, before this PR will throw IllegalStateException: *** with use count: -1
Was this patch authored or co-authored using generative AI tooling?
No.