[SPARK-47903][PYTHON] Add support for remaining scalar types in the PySpark Variant library #46122
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng with parse_json and variant_get
…authentication errors
…hema is variant type
…essions/jsonExpressions.scala Co-authored-by: Hyukjin Kwon <[email protected]>
…park into from_json_variant
…db/spark into python_scalar_variant
gene-db
approved these changes
Apr 19, 2024
Contributor
gene-db
left a comment
gene-db
left a comment
There was a problem hiding this comment.
@harshmotw-db Thanks for supporting these additional types!
LGTM
HyukjinKwon
approved these changes
Apr 22, 2024
Member
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Added support for the
date,timestamp,timestamp_ntz,floatandbinaryscalar types to the variant library in Python. Data of these types can also be extracted now from a variant.Why are the changes needed?
Support for these types was added to the Scala side as part of a recent PR. This PR also adds support for these data types on the PySpark side.
Does this PR introduce any user-facing change?
Yes, users can now use PySpark to extract data of more types from Variants.
How was this patch tested?
Unit tests
Was this patch authored or co-authored using generative AI tooling?
No