[SPARK-47434][WEBUI] Fix statistics link in StreamingQueryPage
#45527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Thank you for making a PR, @HuwCampbell . Please create a new JIRA issue because you cannot make a follow-up PR for the released JIRA issue. Your new JIRA needs to have different Fix Versions.
Contributor
Author
HuwCampbell
changed the title
Member
|
Thank you, @HuwCampbell . |
Member
|
Could you enable GitHub Action on your repository? It seems that CI is not running. |
Member
|
Also, cc @yaooqinn too. |
Related to [Spark-24553] This causes redirect issues when one is using proxy settings.
dongjoon-hyun
changed the title
dongjoon-hyun
changed the title
statistics link in StreamingQueryPage
Member
Would you mind providing before-and-after screenshots in the PR desc? |
Contributor
Author
|
There's not a lot to show. Before the link didn't work (we have a proxy setup on our application and it went to Now the link works. Goes correctly to |
Member
|
Ya, we understand. That's enough. Please attach them to the PR description, @HuwCampbell . |
Member
|
In addition, you can add another screenshot which shows that the previous link doesn't work. |
Contributor
Author
|
Ok |
dongjoon-hyun
approved these changes
Mar 18, 2024
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @HuwCampbell and @yaooqinn .
Merged to master/3.5/3.4.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Mar 18, 2024
### What changes were proposed in this pull request? Like SPARK-24553, this PR aims to fix redirect issues (incorrect 302) when one is using proxy settings. Change the generated link to be consistent with other links and include a trailing slash ### Why are the changes needed? When using a proxy, an invalid redirect is issued if this is not included ### Does this PR introduce _any_ user-facing change? Only that people will be able to use these links if they are using a proxy ### How was this patch tested? With a proxy installed I went to the location this link would generate and could go to the page, when it redirects with the link as it exists. Edit: Further tested by building a version of our application with this patch applied, the links work now. ### Was this patch authored or co-authored using generative AI tooling? No. Page with working link <img width="913" alt="Screenshot 2024-03-18 at 4 45 27 PM" src="https://github.com/apache/spark/assets/5205457/dbcd1ffc-b7e6-4f84-8ca7-602c41202bf3"> Goes correctly to <img width="539" alt="Screenshot 2024-03-18 at 4 45 36 PM" src="https://github.com/apache/spark/assets/5205457/89111c82-b24a-4b33-895f-9c0131e8acb5"> Before it would redirect and we'd get a 404. <img width="639" alt="image" src="https://github.com/apache/spark/assets/5205457/1adfeba1-a1f6-4c35-9c39-e077c680baef"> Closes #45527 from HuwCampbell/patch-1. Authored-by: Huw Campbell <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 9b466d3) Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
pushed a commit
that referenced
this pull request
Mar 18, 2024
### What changes were proposed in this pull request? Like SPARK-24553, this PR aims to fix redirect issues (incorrect 302) when one is using proxy settings. Change the generated link to be consistent with other links and include a trailing slash ### Why are the changes needed? When using a proxy, an invalid redirect is issued if this is not included ### Does this PR introduce _any_ user-facing change? Only that people will be able to use these links if they are using a proxy ### How was this patch tested? With a proxy installed I went to the location this link would generate and could go to the page, when it redirects with the link as it exists. Edit: Further tested by building a version of our application with this patch applied, the links work now. ### Was this patch authored or co-authored using generative AI tooling? No. Page with working link <img width="913" alt="Screenshot 2024-03-18 at 4 45 27 PM" src="https://github.com/apache/spark/assets/5205457/dbcd1ffc-b7e6-4f84-8ca7-602c41202bf3"> Goes correctly to <img width="539" alt="Screenshot 2024-03-18 at 4 45 36 PM" src="https://github.com/apache/spark/assets/5205457/89111c82-b24a-4b33-895f-9c0131e8acb5"> Before it would redirect and we'd get a 404. <img width="639" alt="image" src="https://github.com/apache/spark/assets/5205457/1adfeba1-a1f6-4c35-9c39-e077c680baef"> Closes #45527 from HuwCampbell/patch-1. Authored-by: Huw Campbell <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 9b466d3) Signed-off-by: Dongjoon Hyun <[email protected]>
Member
|
Welcome to the Apache Spark community, @HuwCampbell . I added you to the Apache Spark Contributor group and assigned SPARK-47434 to you. Thank you again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Like SPARK-24553, this PR aims to fix redirect issues (incorrect 302) when one is using proxy settings. Change the generated link to be consistent with other links and include a trailing slash
Why are the changes needed?
When using a proxy, an invalid redirect is issued if this is not included
Does this PR introduce any user-facing change?
Only that people will be able to use these links if they are using a proxy
How was this patch tested?
With a proxy installed I went to the location this link would generate and could go to the page, when it redirects with the link as it exists.
Edit: Further tested by building a version of our application with this patch applied, the links work now.
Was this patch authored or co-authored using generative AI tooling?
No.
Page with working link
Goes correctly to
Before it would redirect and we'd get a 404.