-
Notifications
You must be signed in to change notification settings - Fork 29.3k
[SPARK-42040][SQL] SPJ: Introduce a new API for V2 input partition to report partition statistics #45314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
[SPARK-42040][SQL] SPJ: Introduce a new API for V2 input partition to report partition statistics #45314
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
5961fe7
SPARK-42040: SPJ: Introduce a new API for V2 input partition to repor…
c7e464f
Address comments.
a606175
Merge remote-tracking branch 'upstream/master' into SPARK-42040
8c6c1e0
Merge remote-tracking branch 'upstream/master' into SPARK-42040
c3bcc09
Address new comments
48742a3
Address new comments
9ceaea0
Address new comments
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
36 changes: 36 additions & 0 deletions
36
sql/catalyst/src/main/java/org/apache/spark/sql/connector/read/HasPartitionSize.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| /* | ||
| * Licensed to the Apache Software Foundation (ASF) under one or more | ||
| * contributor license agreements. See the NOTICE file distributed with | ||
| * this work for additional information regarding copyright ownership. | ||
| * The ASF licenses this file to You under the Apache License, Version 2.0 | ||
| * (the "License"); you may not use this file except in compliance with | ||
| * the License. You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package org.apache.spark.sql.connector.read; | ||
|
|
||
| import java.util.OptionalLong; | ||
|
|
||
| /** | ||
| * A mix-in for input partitions whose records are clustered on the same set of partition keys | ||
| * (provided via {@link SupportsReportPartitioning}, see below). Data sources can opt-in to | ||
| * implement this interface for the partitions they report to Spark, which will use the info | ||
| * to decide whether partition grouping should be applied or not. | ||
| * | ||
| * @see org.apache.spark.sql.connector.read.SupportsReportPartitioning | ||
| * @since 4.0.0 | ||
| */ | ||
| public interface HasPartitionSize extends InputPartition { | ||
| /** | ||
| * Returns the value of the partition size associated to this partition. | ||
| */ | ||
| OptionalLong partitionSizeInBytes(); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we can make this more general and support partition level stats as well, like number of rows.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @sunchao for review, and this is a good suggestion, i check the Iceberg code, it includes the sizeBytes and estimatedRowsCount, filesCount. Let me address this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in latest PR.