[MINOR][SQL] Remove out-of-dated comment in CollectLimitExec
#45311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
viirya
changed the title
CollectLimitExecCollectLimitExec
viirya
changed the title
CollectLimitExecCollectLimitExec
viirya
commented
Feb 28, 2024
| // collect the first `limit` + `offset` elements and then to drop the first `offset` elements. | ||
| // For example: limit is 1 and offset is 2 and the child output two partition. | ||
| // The first partition output [1, 2] and the Second partition output [3, 4, 5]. | ||
| // Then [1, 2, 3] will be taken and output [3]. |
Member
Author
There was a problem hiding this comment.
While I reviewed something related to this, the comment read confused to me. I traced it to original PR #35975, but the code was already updated by later PRs. This comment is actually out-of-dated and not matched to the code.
HyukjinKwon
approved these changes
Feb 28, 2024
LuciferYang
approved these changes
Feb 28, 2024
Contributor
|
Merged into master for Spark 4.0. Thanks @viirya @HyukjinKwon |
Member
Author
|
Thank you @LuciferYang @HyukjinKwon @dongjoon-hyun |
TakawaAkirayo
pushed a commit
to TakawaAkirayo/spark
that referenced
this pull request
Mar 4, 2024
### What changes were proposed in this pull request? This patch removes an out-of-dated code comment that was added by apache#35975. ### Why are the changes needed? Removed out-of-dated comment to reduce misunderstanding and confusion. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing test ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#45311 from viirya/remove_comment. Authored-by: Liang-Chi Hsieh <[email protected]> Signed-off-by: yangjie01 <[email protected]>
ericm-db
pushed a commit
to ericm-db/spark
that referenced
this pull request
Mar 5, 2024
### What changes were proposed in this pull request? This patch removes an out-of-dated code comment that was added by apache#35975. ### Why are the changes needed? Removed out-of-dated comment to reduce misunderstanding and confusion. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing test ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#45311 from viirya/remove_comment. Authored-by: Liang-Chi Hsieh <[email protected]> Signed-off-by: yangjie01 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This patch removes an out-of-dated code comment that was added by #35975.
Why are the changes needed?
Removed out-of-dated comment to reduce misunderstanding and confusion.
Does this PR introduce any user-facing change?
No
How was this patch tested?
Existing test
Was this patch authored or co-authored using generative AI tooling?
No