[SPARK-47185][SS][TESTS] Increase timeout between actions in KafkaContinuousSourceSuite #45283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
dongjoon-hyun
approved these changes
Feb 27, 2024
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you for doubling the timeout, @HyukjinKwon .
Member
|
Merged to master for Apache Spark 4.0.0. |
HyukjinKwon
added a commit
that referenced
this pull request
Feb 28, 2024
…e, and reduce the resource usage ### What changes were proposed in this pull request? This PR is a followup of #45272, #45268, #45264 and #45283 that increase timeout more and decrease the resource needed during the CI. ### Why are the changes needed? To make the scheduled build pass https://github.com/apache/spark/actions/runs/8054862135/job/22053180441. At least as far as I can tell, those changes are effective (makes tests less flaky and less fail). ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? I manually ran then via IDE. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #45297 from HyukjinKwon/SPARK-47185-SPARK-47181-followup. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
TakawaAkirayo
pushed a commit
to TakawaAkirayo/spark
that referenced
this pull request
Mar 4, 2024
…tinuousSourceSuite ### What changes were proposed in this pull request? This PR proposes to increase the timeout between between actions in `KafkaContinuousSourceSuite`. ### Why are the changes needed? In Mac OS build, those tests fail indeterministically, see - https://github.com/apache/spark/actions/runs/8054862135/job/22000404856 - https://github.com/apache/spark/actions/runs/8040413156/job/21958488693 - https://github.com/apache/spark/actions/runs/8032862212/job/21942732320 - https://github.com/apache/spark/actions/runs/8024427919/job/21937366481 `KafkaContinuousSourceSuite` is specifically slow in Mac OS. Kafka producers send the messages correctly, but the consumers can't get the messages for some reasons. You can't get the offsets for long time. This is not an issue in micro batch but I fail to identify the difference. I just decided to increase the timeout between actions for now. This is more just a workaround. ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? Manually tested in my Mac. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45283 from HyukjinKwon/SPARK-47185. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
TakawaAkirayo
pushed a commit
to TakawaAkirayo/spark
that referenced
this pull request
Mar 4, 2024
…e, and reduce the resource usage ### What changes were proposed in this pull request? This PR is a followup of apache#45272, apache#45268, apache#45264 and apache#45283 that increase timeout more and decrease the resource needed during the CI. ### Why are the changes needed? To make the scheduled build pass https://github.com/apache/spark/actions/runs/8054862135/job/22053180441. At least as far as I can tell, those changes are effective (makes tests less flaky and less fail). ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? I manually ran then via IDE. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45297 from HyukjinKwon/SPARK-47185-SPARK-47181-followup. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
ericm-db
pushed a commit
to ericm-db/spark
that referenced
this pull request
Mar 5, 2024
…tinuousSourceSuite ### What changes were proposed in this pull request? This PR proposes to increase the timeout between between actions in `KafkaContinuousSourceSuite`. ### Why are the changes needed? In Mac OS build, those tests fail indeterministically, see - https://github.com/apache/spark/actions/runs/8054862135/job/22000404856 - https://github.com/apache/spark/actions/runs/8040413156/job/21958488693 - https://github.com/apache/spark/actions/runs/8032862212/job/21942732320 - https://github.com/apache/spark/actions/runs/8024427919/job/21937366481 `KafkaContinuousSourceSuite` is specifically slow in Mac OS. Kafka producers send the messages correctly, but the consumers can't get the messages for some reasons. You can't get the offsets for long time. This is not an issue in micro batch but I fail to identify the difference. I just decided to increase the timeout between actions for now. This is more just a workaround. ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? Manually tested in my Mac. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45283 from HyukjinKwon/SPARK-47185. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
ericm-db
pushed a commit
to ericm-db/spark
that referenced
this pull request
Mar 5, 2024
…e, and reduce the resource usage ### What changes were proposed in this pull request? This PR is a followup of apache#45272, apache#45268, apache#45264 and apache#45283 that increase timeout more and decrease the resource needed during the CI. ### Why are the changes needed? To make the scheduled build pass https://github.com/apache/spark/actions/runs/8054862135/job/22053180441. At least as far as I can tell, those changes are effective (makes tests less flaky and less fail). ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? I manually ran then via IDE. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45297 from HyukjinKwon/SPARK-47185-SPARK-47181-followup. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
snmvaughan
pushed a commit
to snmvaughan/spark
that referenced
this pull request
Mar 26, 2024
…tinuousSourceSuite ### What changes were proposed in this pull request? This PR proposes to increase the timeout between between actions in `KafkaContinuousSourceSuite`. ### Why are the changes needed? In Mac OS build, those tests fail indeterministically, see - https://github.com/apache/spark/actions/runs/8054862135/job/22000404856 - https://github.com/apache/spark/actions/runs/8040413156/job/21958488693 - https://github.com/apache/spark/actions/runs/8032862212/job/21942732320 - https://github.com/apache/spark/actions/runs/8024427919/job/21937366481 `KafkaContinuousSourceSuite` is specifically slow in Mac OS. Kafka producers send the messages correctly, but the consumers can't get the messages for some reasons. You can't get the offsets for long time. This is not an issue in micro batch but I fail to identify the difference. I just decided to increase the timeout between actions for now. This is more just a workaround. ### Does this PR introduce _any_ user-facing change? No, test-only. ### How was this patch tested? Manually tested in my Mac. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#45283 from HyukjinKwon/SPARK-47185. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to increase the timeout between between actions in
KafkaContinuousSourceSuite.Why are the changes needed?
In Mac OS build, those tests fail indeterministically, see
KafkaContinuousSourceSuiteis specifically slow in Mac OS. Kafka producers send the messages correctly, but the consumers can't get the messages for some reasons. You can't get the offsets for long time. This is not an issue in micro batch but I fail to identify the difference.I just decided to increase the timeout between actions for now. This is more just a workaround.
Does this PR introduce any user-facing change?
No, test-only.
How was this patch tested?
Manually tested in my Mac.
Was this patch authored or co-authored using generative AI tooling?
No.