[SPARK-47170][BUILD][CONNECT] Remove jakarta.servlet-api and javax.servlet-api dependency scope in connect/server module
#45258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HiuKwok
changed the title
jakarta.servlet-api and javax.servlet-apijakarta.servlet-api and javax.servlet-api
Contributor
Author
|
@dongjoon-hyun would you mind having a look at this, thanks :) |
dongjoon-hyun
changed the title
jakarta.servlet-api and javax.servlet-apijakarta.servlet-api and javax.servlet-api dependency scope in connect/server module
Member
|
Thank yo, @HiuKwok . Merged to master. |
TakawaAkirayo
pushed a commit
to TakawaAkirayo/spark
that referenced
this pull request
Mar 4, 2024
….servlet-api` dependency scope in `connect/server` module ### What changes were proposed in this pull request? This is a follow up change from apache#45154, to remove redundant `<scope>` for both servlet-api as `compile` is the default scope. ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI build ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#45258 from HiuKwok/ft-hf-jetty-deps-scope. Authored-by: HiuFung Kwok <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
ericm-db
pushed a commit
to ericm-db/spark
that referenced
this pull request
Mar 5, 2024
….servlet-api` dependency scope in `connect/server` module ### What changes were proposed in this pull request? This is a follow up change from apache#45154, to remove redundant `<scope>` for both servlet-api as `compile` is the default scope. ### Why are the changes needed? ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? CI build ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#45258 from HiuKwok/ft-hf-jetty-deps-scope. Authored-by: HiuFung Kwok <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow up change from #45154, to remove redundant
<scope>for both servlet-api ascompileis the default scope.Why are the changes needed?
Does this PR introduce any user-facing change?
No
How was this patch tested?
CI build
Was this patch authored or co-authored using generative AI tooling?
No