[SPARK-47060][SQL][TESTS] Check SparkIllegalArgumentException instead of IllegalArgumentException in catalyst
#45118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
changed the title
SparkIllegalArgumentException instead of IllegalArgumentException in catalystSparkIllegalArgumentException instead of IllegalArgumentException in catalyst
cloud-fan
approved these changes
Feb 16, 2024
Member
Author
|
Merging to master. Thank you, @cloud-fan for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to use
checkError()in tests ofcatalystto checkSparkIllegalArgumentException, and its fields.Why are the changes needed?
By checking
SparkIllegalArgumentExceptionand its fields like error class and message parameters prevents replacingSparkIllegalArgumentExceptionback toIllegalArgumentException.Does this PR introduce any user-facing change?
No.
How was this patch tested?
By running the modified test suites.
Was this patch authored or co-authored using generative AI tooling?
No.