Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Feb 12, 2024

What changes were proposed in this pull request?

This PR aims to update docker-integration-tests test module to use the latest Guava test dependency. Specifically,

  • Switch from provided dependency to test dependency
  • Upgrade from version 19.0 to 33.0.0-jre.

Why are the changes needed?

Previously, docker-integration-tests uses Guava 19.0 dependency as provided scope because docker-java-core is using Guava 19.0 still.

Does this PR introduce any user-facing change?

No, docker-integration-tests is an integration test module.

How was this patch tested?

Pass the CIs.

Was this patch authored or co-authored using generative AI tooling?

No.

@github-actions github-actions bot added the BUILD label Feb 12, 2024
@dongjoon-hyun dongjoon-hyun marked this pull request as draft February 12, 2024 21:24
@dongjoon-hyun
Copy link
Member Author

To @LuciferYang , this PR is based on your comment. Last time, we didn't try this eagerly and simply sticked to the provided dependency from docker-java.

@dongjoon-hyun dongjoon-hyun marked this pull request as ready for review February 12, 2024 22:10
@dongjoon-hyun
Copy link
Member Author

docker-integration-tests passed.

Screenshot 2024-02-12 at 14 10 34

@LuciferYang
Copy link
Contributor

Merged into master. Thanks @dongjoon-hyun @HyukjinKwon ~ Happy Lunar New Year ~

@dongjoon-hyun
Copy link
Member Author

Thank you, @LuciferYang !

@dongjoon-hyun
Copy link
Member Author

Ya, Happy Lunar New Year, @LuciferYang . 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants