Skip to content

[SPARK-45807][SQL] Return View after calling replaceView(..) #44970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nastra wants to merge 1 commit into from
Closed

[SPARK-45807][SQL] Return View after calling replaceView(..) #44970

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions sql/catalyst/src/main/java/org/apache/spark/sql/connector/catalog/ViewCatalog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ default boolean viewExists(Identifier ident) {
* Create a view in the catalog.
*
* @param viewInfo the info class holding all view information
* @return the view created
* @return the created view. This can be null if getting the metadata for the view is expensive
* @throws ViewAlreadyExistsException If a view or table already exists for the identifier
* @throws NoSuchNamespaceException If the identifier namespace does not exist (optional)
*/
Expand All @@ -129,10 +129,12 @@ default boolean viewExists(Identifier ident) {
*
* @param viewInfo the info class holding all view information
* @param orCreate create the view if it doesn't exist
* @return the created/replaced view. This can be null if getting the metadata
* for the view is expensive
* @throws NoSuchViewException If the view doesn't exist or is a table
* @throws NoSuchNamespaceException If the identifier namespace does not exist (optional)
*/
default void replaceView(
default View replaceView(
ViewInfo viewInfo,
boolean orCreate)
throws NoSuchViewException, NoSuchNamespaceException {
Expand All @@ -143,7 +145,7 @@ default void replaceView(
}

try {
createView(viewInfo);
return createView(viewInfo);
} catch (ViewAlreadyExistsException e) {
throw new RuntimeException("Race condition when creating/replacing view", e);
}
Expand Down