[SPARK-46677][CONNECT][FOLLOWUP] Fix dataset.col("*") in Scala Client
#44748
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Jan 16, 2024
LuciferYang
approved these changes
Jan 16, 2024
Contributor
Author
|
There is an issue on |
zhengruifeng
changed the title
dataset.col("*") in Scala Clientdataset.col("*") in Scala Client
Contributor
|
maybe we should use |
zhengruifeng
changed the title
dataset.col("*") in Scala Clientdataset.col("*") in Scala Client
zhengruifeng
force-pushed
the
connect_scala_df_star
branch
from
edc105a to
763c0e5
Compare
zhengruifeng
changed the title
dataset.col("*") in Scala Clientdataset.col("*") in Scala Client
Contributor
Author
|
merged to master, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
this PR is a followup of #44689, to fix
dataset.col("*")in Scala ClientWhy are the changes needed?
fix
dataset.col("*")resolutionDoes this PR introduce any user-facing change?
yes, bug fix
How was this patch tested?
added ut
Was this patch authored or co-authored using generative AI tooling?
no