[SPARK-46717][CORE] Simplify ReloadingX509TrustManager by the exit operation only depend on interrupt thread.
#44720
+2
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ion only depend on interrupt
mridulm
reviewed
Jan 15, 2024
Contributor
mridulm
left a comment
mridulm
left a comment
There was a problem hiding this comment.
Looks good to me.
+CC @hasnain-db
beliefer
changed the title
Contributor
Author
Contributor
|
also cc @mridulm |
Member
|
If the interrupt happens while it's running the reload block, will the next call to sleep() yield an InterruptedException? the logic now depends on this |
Contributor
Author
Yes. sleep() always check the interrupt signal. |
dongjoon-hyun
changed the title
ReloadingX509TrustManager by the exit operation only depend on interrupt thread.
Member
|
Merged to master for Apache Spark 4.0.0. |
Contributor
Author
|
@dongjoon-hyun @mridulm @srowen @LuciferYang Thank you! |
Contributor
|
thanks for doing this @beliefer ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR propose to simplify the
ReloadingX509TrustManager.Why are the changes needed?
Currently, close or destroy
ReloadingX509TrustManagerdepend on interrupt thread and the volatile variablerunning.In fact, we can change the
runningto a local variable on stack and let the close operation ofReloadingX509TrustManageronly depend on interrupt thread.Does this PR introduce any user-facing change?
'No'.
How was this patch tested?
GA tests.
Was this patch authored or co-authored using generative AI tooling?
'No'.