[SPARK-46693][SQL] Inject LocalLimitExec when matching OffsetAndLimit or LimitAndOffset #44699
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
approved these changes
Jan 12, 2024
Contributor
|
also cc @beliefer |
yaooqinn
reviewed
Jan 12, 2024
sql/core/src/test/scala/org/apache/spark/sql/execution/PlannerSuite.scala
Outdated
Show resolved
Hide resolved
yaooqinn
reviewed
Jan 12, 2024
sql/core/src/test/scala/org/apache/spark/sql/execution/PlannerSuite.scala
Outdated
Show resolved
Hide resolved
yaooqinn
reviewed
Jan 12, 2024
sql/core/src/test/scala/org/apache/spark/sql/execution/PlannerSuite.scala
Outdated
Show resolved
Hide resolved
dongjoon-hyun
approved these changes
Jan 13, 2024
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Thank you, @n-young-db and all.
Merged to master.
Member
|
Welcome to the Apache Spark community, @n-young-db . |
Member
|
BTW, @n-young-db , according to the commit log, SPARK-46274 is your contribution too, right? It seems that it's assigned to someone-else currently. Is there any reason for this contributor mismatch, @n-young-db and @cloud-fan ? |
Member
|
late lgtm |
Contributor
|
@dongjoon-hyun thanks for catching it! it's a mistake, I've updated the assignee. |
Contributor
Author
|
@dongjoon-hyun I hadn't gotten my JIRA account yet so I had someone else create the ticket for me; thank you for catching and fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Why are the changes needed?
Originally,
OffsetAndLimitandLimitAndOffsetmatch cases were matching then dropping a LocalLimit node. Adds this LocalLimitExec node to the physical plan to improve efficiency. Note that this was not a correctness bug since not applying LocalLimit only leads to larger intermediate shuffles / nodes.Does this PR introduce any user-facing change?
No.
How was this patch tested?
UT
Was this patch authored or co-authored using generative AI tooling?
No