[SPARK-46474][INFRA] Upgrade upload-artifact action to v4 #44662
Conversation
panbingkun
changed the title
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: test-results-${{ matrix.modules }}--${{ matrix.java }}-${{ inputs.hadoop }}-hive2.3 | ||
| name: test-results-${{ matrix.modules }}--${{ matrix.java }}-${{ inputs.hadoop }}-hive2.3-${{ env.PYTHON_TO_TEST }} |
There was a problem hiding this comment.
This is to fix the breaking change feature of the new version v4:
https://github.com/actions/upload-artifact?tab=readme-ov-file#breaking-changes
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: unit-tests-log-${{ matrix.modules }}--${{ matrix.java }}-${{ inputs.hadoop }}-hive2.3 | ||
| name: unit-tests-log-${{ matrix.modules }}--${{ matrix.java }}-${{ inputs.hadoop }}-hive2.3-${{ env.PYTHON_TO_TEST }} |
|
cc @HyukjinKwon @dongjoon-hyun @zhengruifeng Why does this PR #44438 cause upload failure in
|
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Thank you, @panbingkun .
cc @HyukjinKwon
|
Merged to master. |
|
Oh, it seems to fail again.
|
|
Unfortunately, let me revert this again. |
|
This is reverted via c18c87d |
|
Thanks for reverting it 👍 |
|
I also noticed that, it's strange, I will investigate again. |
It seems that the ` PYTHON_TO_TEST` environment variable is not effective,
`Python 3.9 still` runs in various workflows, which doesn't seem to meet our expectations.
|
|
This issue is also the reason why this PR was unsuccessful. I have found another issue, we need to use 1.python 3.10 2.python 3.11 cc @dongjoon-hyun @HyukjinKwon |
### What changes were proposed in this pull request? The pr aims to upgrade upload-artifact action from v3 to v4. After PR #44698, our environment variable(`PYTHON_TO_TEST`) is correctly passed and assigned value. We will bring back this PR: #44662 ### Why are the changes needed? - v4.0.0 release notes: https://github.com/actions/upload-artifact/releases/tag/v4.0.0 They have numerous performance and behavioral improvements. - v3 VS v4: actions/upload-artifact@v3...v4.0.0 ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Pass GA. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #44728 from panbingkun/SPARK-46474_GO_AHEAD. Authored-by: panbingkun <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
3 participants
What changes were proposed in this pull request?
The pr aims to upgrade upload-artifact action from v3 to v4.
The pr is also an improvement after the reversal of #44438.
Why are the changes needed?
v4.0.0 release notes: https://github.com/actions/upload-artifact/releases/tag/v4.0.0
They have numerous performance and behavioral improvements.
v3 VS v4: actions/upload-artifact@v3...v4.0.0
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Pass GA.
Was this patch authored or co-authored using generative AI tooling?
No.