Skip to content

Conversation

@zhengruifeng
Copy link
Contributor

@zhengruifeng zhengruifeng commented Jan 9, 2024

What changes were proposed in this pull request?

Retry test_map_in_pandas_with_column_vector and its parity test

Why are the changes needed?

I am seeing this test and its parity test failing from time to time, and then fails pyspark-sql and pyspark-connect.

It seems due to some log4j issue, e.g

https://github.com/zhengruifeng/spark/actions/runs/7459243602/job/20294868487

test_map_in_pandas_with_column_vector (pyspark.sql.tests.pandas.test_pandas_map.MapInPandasTests) ... ERROR StatusConsoleListener An exception occurred processing Appender File
 java.lang.IllegalArgumentException: found 1 argument placeholders, but provided 0 for pattern `0, VisitedIndex{visitedIndexes={}}: [] r:0`
	at org.apache.logging.log4j.message.ParameterFormatter.formatMessage(ParameterFormatter.java:233)

https://github.com/apache/spark/actions/runs/7460093200/job/20297508703

  test_map_in_pandas_with_column_vector (pyspark.sql.tests.connect.test_parity_pandas_map.MapInPandasParityTests) ... ERROR StatusConsoleListener An exception occurred processing Appender File
 java.lang.IllegalArgumentException: found 1 argument placeholders, but provided 0 for pattern `0, VisitedIndex{visitedIndexes={}}: [] r:0`
	at org.apache.logging.log4j.message.ParameterFormatter.formatMessage(ParameterFormatter.java:233)
	at org.apache.logging.log4j.message.ParameterizedMessage.formatTo(ParameterizedMessage.java:266)
	at 

this PR simply attempt to retry it after failures

Does this PR introduce any user-facing change?

no, test-only

How was this patch tested?

ci

Was this patch authored or co-authored using generative AI tooling?

no

@zhengruifeng zhengruifeng changed the title [MINOR][PYTHON][TESTS] Retry test_map_in_pandas_with_column_vector and its parity test [MINOR][PYTHON][TESTS] Retry test_map_in_pandas_with_column_vector Jan 9, 2024
empty
@HyukjinKwon
Copy link
Member

Merged to master.

@zhengruifeng zhengruifeng deleted the py_test_retry_mip branch January 10, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants