[SPARK-46622][CORE] Override toString method for o.a.s.network.shuffledb.StoreVersion
#44624
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mridulm
approved these changes
Jan 9, 2024
Contributor
mridulm
left a comment
mridulm
left a comment
There was a problem hiding this comment.
LGTM, thanks for fixing this !
Member
|
Merged to master for Apache Spark 4.0.0. |
Contributor
Author
|
Thanks @dongjoon-hyun and @mridulm |
FMX
pushed a commit
to apache/celeborn
that referenced
this pull request
Mar 11, 2024
### What changes were proposed in this pull request? Override `toString` method for `StoreVersion`. ### Why are the changes needed? Avoid displaying `StoreVersionhashCode` in the `IOException` thrown after the checkVersion check fails in `RocksDBProvider`/`LevelDBProvider`, show something like: ``` cannot read state DB with version org.apache.celeborn.service.deploy.worker.shuffledb.StoreVersion1f, incompatible with current version org.apache.celeborn.service.deploy.worker.shuffledb.StoreVersion3e ``` Backport apache/spark#44624. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? - `DBProviderSuiteJ` Closes #2372 from SteNicholas/CELEBORN-1316. Authored-by: SteNicholas <[email protected]> Signed-off-by: mingji <[email protected]>
SteNicholas
added a commit
to apache/celeborn
that referenced
this pull request
Apr 23, 2024
### What changes were proposed in this pull request? Override `toString` method for `StoreVersion`. ### Why are the changes needed? Avoid displaying `StoreVersionhashCode` in the `IOException` thrown after the checkVersion check fails in `RocksDBProvider`/`LevelDBProvider`, show something like: ``` cannot read state DB with version org.apache.celeborn.service.deploy.worker.shuffledb.StoreVersion1f, incompatible with current version org.apache.celeborn.service.deploy.worker.shuffledb.StoreVersion3e ``` Backport apache/spark#44624. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? - `DBProviderSuiteJ` Closes #2372 from SteNicholas/CELEBORN-1316. Authored-by: SteNicholas <[email protected]> Signed-off-by: mingji <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr aims to override
toStringmethod foro.a.s.network.shuffledb.StoreVersionWhy are the changes needed?
Avoid displaying
StoreVersion@hashCodein theIOExceptionthrown after the checkVersion check fails in RocksDBProvider/LevelDBProvider, show something like:Does this PR introduce any user-facing change?
No
How was this patch tested?
Add new test
Was this patch authored or co-authored using generative AI tooling?
No