[SPARK-46592][DOCKER][TESTS][FOLLOWUP] Add newline to ORACLE Docker preparation sql #44609
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @dongjoon-hyun @MaxGekk @LuciferYang. Sorry for the mistake; I intended to test SPARK-46592 after I went home on my Mac with Intel chips, but I fell asleep early. |
MaxGekk
approved these changes
Jan 5, 2024
LuciferYang
approved these changes
Jan 5, 2024
Member
|
Docker tests passed. +1, LGTM. Merging to master. |
vinodkc
pushed a commit
to vinodkc/spark
that referenced
this pull request
Jan 5, 2024
…reparation sql ### What changes were proposed in this pull request? `semicolon` is not able to break SQLs in a file into separated statements ### Why are the changes needed? a followup for SPARK-46592 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? Check the Oracle docker log #### Before ``` STDOUT: CONTAINER: running /docker-entrypoint-initdb.d/install.sql ... STDOUT: ALTER SESSION SET DDL_LOCK_TIMEOUT = 30;ALTER USER SYSTEM IDENTIFIED BY "Th1s1sThe0racle#Pass" STDOUT: * STDOUT: ERROR at line 1: STDOUT: ORA-00922: missing or invalid option STDOUT: Help: https://docs.oracle.com/error-help/db/ora-00922/ ``` #### After ``` STDOUT: CONTAINER: DONE: running /docker-entrypoint-initdb.d/install.sql STDOUT: Session altered. STDOUT: User altered. ``` ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#44609 from yaooqinn/SPARK-46592-F. Authored-by: Kent Yao <[email protected]> Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
semicolonis not able to break SQLs in a file into separated statementsWhy are the changes needed?
a followup for SPARK-46592
Does this PR introduce any user-facing change?
no
How was this patch tested?
Check the Oracle docker log
Before
After
Was this patch authored or co-authored using generative AI tooling?
no