[SPARK-46593][PS][TESTS] Refactor data_type_ops tests
#44592
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
approved these changes
Jan 5, 2024
Contributor
Author
|
thanks @HyukjinKwon for the reviews |
Contributor
Author
|
sorry @HyukjinKwon , I just find that after this PR, the changed parity tests are run on non-connect mode, let me revert it first |
zhengruifeng
added a commit
that referenced
this pull request
Jan 5, 2024
### What changes were proposed in this pull request? revert #44592 which happened to disable the parity tests they should be run on connect mode, but actually run on vanilla mode Closes #44605 from zhengruifeng/revert_46593. Authored-by: Ruifeng Zheng <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]>
vinodkc
pushed a commit
to vinodkc/spark
that referenced
this pull request
Jan 5, 2024
### What changes were proposed in this pull request? Refactor `data_type_ops` tests: deduplicate the `OpsTestBase` ### Why are the changes needed? make `OpsTestBase` reusable and reuse it in the parity tests ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? ci ### Was this patch authored or co-authored using generative AI tooling? no Closes apache#44592 from zhengruifeng/ps_test_data_type_ops. Authored-by: Ruifeng Zheng <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]>
vinodkc
pushed a commit
to vinodkc/spark
that referenced
this pull request
Jan 5, 2024
### What changes were proposed in this pull request? revert apache#44592 which happened to disable the parity tests they should be run on connect mode, but actually run on vanilla mode Closes apache#44605 from zhengruifeng/revert_46593. Authored-by: Ruifeng Zheng <[email protected]> Signed-off-by: Ruifeng Zheng <[email protected]>
Member
|
sure |
HyukjinKwon
pushed a commit
that referenced
this pull request
Jan 7, 2024
### What changes were proposed in this pull request? 1, check the testing mode: - `test_assert_vanilla_mode` in `ReusedPySparkTestCase` - `test_assert_remote_mode` in `ReusedConnectTestCase` use different function names in case a test suite inherit them both 2, fix the incorrect testing mode introduced in #44196 ### Why are the changes needed? incorrect usage of `PandasOnSparkTestCase` (subclass of `ReusedPySparkTestCase`) in parity tests cause test with vanilla Spark Session: #44196 #44592 ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? ci, added UT ### Was this patch authored or co-authored using generative AI tooling? no Closes #44611 from zhengruifeng/py_testing_mode. Authored-by: Ruifeng Zheng <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
HyukjinKwon
pushed a commit
that referenced
this pull request
Jan 10, 2024
### What changes were proposed in this pull request? Refactor `data_type_ops` tests again (the previous pr #44592 has been reverted) ### Why are the changes needed? make `OpsTestBase` reusable and reuse it in the parity tests ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? ci ### Was this patch authored or co-authored using generative AI tooling? no Closes #44637 from zhengruifeng/ps_test_rere_data_type_ops_again. Authored-by: Ruifeng Zheng <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Refactor
data_type_opstests: deduplicate theOpsTestBaseWhy are the changes needed?
make
OpsTestBasereusable and reuse it in the parity testsDoes this PR introduce any user-facing change?
no
How was this patch tested?
ci
Was this patch authored or co-authored using generative AI tooling?
no