[SPARK-46576][SQL] Improve error messages for unsupported data source save mode #44576
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
approved these changes
Jan 3, 2024
Member
|
Waiting for CI. |
Member
|
+1, LGTM. Merging to master. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Jan 19, 2024
…ata source save mode ### What changes were proposed in this pull request? This PR is a follow up for #44576 to change the single quotes to double quotes for data source name. ### Why are the changes needed? To make the error message format consistent. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Existing tests ### Was this patch authored or co-authored using generative AI tooling? No Closes #44790 from allisonwang-db/spark-46576-follow-up. Authored-by: allisonwang-db <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR renames the error class
_LEGACY_ERROR_TEMP_1308toUNSUPPORTED_DATA_SOURCE_SAVE_MODEand improves its error messages.Why are the changes needed?
To make the error more user-friendly.
Does this PR introduce any user-facing change?
No
How was this patch tested?
New unit tests
Was this patch authored or co-authored using generative AI tooling?
No