[SPARK-46560][PYTHON][DOCS] Refine docstring reverse/map_contains_key
#44561
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
reviewed
Jan 2, 2024
| Examples | ||
| -------- | ||
| Example 1: Reverse a string | ||
|
|
Contributor
There was a problem hiding this comment.
Let's standardize the format:
- import functions as sf and import other necessaries
- try not to use
.alias - perhaps
showis clearer thancollectwhen displaying results.
LuciferYang
reviewed
Jan 3, 2024
itholic
approved these changes
Jan 3, 2024
Co-authored-by: YangJie <[email protected]>
dongjoon-hyun
approved these changes
Jan 4, 2024
zhengruifeng
approved these changes
Jan 4, 2024
LuciferYang
approved these changes
Jan 4, 2024
zhengruifeng
reviewed
Jan 4, 2024
|
|
||
| Example 2: Reverse an array | ||
|
|
||
| >>> df = spark.createDataFrame([([2, 1, 3],) ,([1],) ,([],)], ['data']) |
Contributor
There was a problem hiding this comment.
nit, is this line duplicated?
Contributor
Author
There was a problem hiding this comment.
For self-contained, the data is also repeated once in each example.
Contributor
There was a problem hiding this comment.
I mean df is defined twice in this example
Contributor
Author
There was a problem hiding this comment.
Oh, I made a mistake. It was defined twice in this example and let me to remove it.
Done.
vinodkc
pushed a commit
to vinodkc/spark
that referenced
this pull request
Jan 5, 2024
### What changes were proposed in this pull request? The pr aims to refine docstring of `reverse/map_contains_key`. ### Why are the changes needed? To improve PySpark documentation. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Manually test. ### Was this patch authored or co-authored using generative AI tooling? No. Closes apache#44561 from panbingkun/SPARK-46560. Lead-authored-by: panbingkun <[email protected]> Co-authored-by: panbingkun <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The pr aims to refine docstring of
reverse/map_contains_key.Why are the changes needed?
To improve PySpark documentation.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Manually test.
Was this patch authored or co-authored using generative AI tooling?
No.