Skip to content

[SPARK-46547][SS] Swallow non-fatal exception in maintenance task to avoid deadlock between maintenance thread and streaming aggregation operator #44542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
anishshri-db wants to merge 7 commits into from
Closed

[SPARK-46547][SS] Swallow non-fatal exception in maintenance task to avoid deadlock between maintenance thread and streaming aggregation operator #44542

Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c6a3a7e
[SPARK-46547] Fix deadlock between maintenance thread and streaming a…
anishshri-db Dec 30, 2023
56a4862
Merge branch 'master' into task/SPARK-46547
anishshri-db Dec 30, 2023
5daa806
Use light weight abort method within completionIterator
anishshri-db Jan 1, 2024
8bbaf8f
Revert "Use light weight abort method within completionIterator"
anishshri-db Jan 9, 2024
2acba49
Change to address Jungtaek's comments
anishshri-db Jan 9, 2024
4f676f4
Change to address Jungtaek's comments
anishshri-db Jan 10, 2024
a7b4f16
Change to address Raghu's comments
anishshri-db Jan 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion ...main/scala/org/apache/spark/sql/execution/streaming/state/RocksDBStateStoreProvider.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,8 @@ package org.apache.spark.sql.execution.streaming.state

import java.io._

import scala.util.control.NonFatal

import org.apache.hadoop.conf.Configuration

import org.apache.spark.{SparkConf, SparkEnv}
Expand Down Expand Up @@ -233,7 +235,12 @@ private[sql] class RocksDBStateStoreProvider
}

override def doMaintenance(): Unit = {
rocksDB.doMaintenance()
try {
rocksDB.doMaintenance()
} catch {
case NonFatal(ex) =>
logWarning(s"Error performing maintenance operations with exception=$ex")

@rangadi rangadi Jan 10, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change this to include full stacktrace logWarning("...", ex)

@rangadi rangadi Jan 10, 2024

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also make it explicit that this error is ignored in the log.

@anishshri-db anishshri-db Jan 10, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done - updated the PR

}
}

override def close(): Unit = {
Expand Down