[SPARK-46509][CORE][SS] Replace .reverse.find with .findLast
#44495
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
changed the title
reverse.find with findLast.reverse.find with findLast
LuciferYang
changed the title
.reverse.find with findLast.reverse.find with .findLast
LuciferYang
changed the title
.reverse.find with .findLast.reverse.find with .findLast
dongjoon-hyun
approved these changes
Dec 30, 2023
Member
|
+1, LGTM. Merged to master. Thank you, @LuciferYang . |
Contributor
Author
|
Thanks @dongjoon-hyun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr aims to replace
.reverse.findwith.findLastin Spark code.Why are the changes needed?
.findLastseems more concise..reverseinvolves a copy of the collection, whileStringOps/ArrayOps.findLastwraps the input data into aReverseIteratorto avoid collection copying.Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass GitHub Actions
Was this patch authored or co-authored using generative AI tooling?
No