Skip to content

Conversation

@zhengruifeng
Copy link
Contributor

What changes were proposed in this pull request?

Retain plan_id in resolveOperators

Why are the changes needed?

another attempt to fix #44454

Does this PR introduce any user-facing change?

no

How was this patch tested?

added ut

Was this patch authored or co-authored using generative AI tooling?

no

@zhengruifeng
Copy link
Contributor Author

zhengruifeng commented Dec 22, 2023

this is the previous approach to fix missing plan_id issue:
1, figure out what rules drop the plan_id tag;
2, use copyTagsFrom to copy the tag from old plan to new plan;

Both UnpivotCoercion and ResolveUnpivot leverage resolveOperatorsDownWithPruning, so I'm trying to fix it by making resolveOperatorsDownWithPruning keep the plan_id tag;

cc @cloud-fan @HyukjinKwon

@zhengruifeng
Copy link
Contributor Author

close in favor of #44462

@zhengruifeng zhengruifeng deleted the resolve_helper_plan_id branch December 29, 2023 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant