[SPARK-46380][SQL][FOLLOWUP] Simplify the code for ResolveInlineTables and ResolveInlineTablesSuite #44447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beliefer
force-pushed
the
SPARK-46380_followup
branch
from
3ceb152 to
2fd000e
Compare
Contributor
Author
|
ping @dbatomic cc @cloud-fan @MaxGekk @srielau |
…s and ResolveInlineTablesSuite
beliefer
force-pushed
the
SPARK-46380_followup
branch
from
2fd000e to
d05da21
Compare
Contributor
|
LGTM. Thanks for following up, this indeed is cleaner and more testable. |
cloud-fan
approved these changes
Dec 22, 2023
Contributor
|
thanks, merging to master! |
Contributor
Author
|
@cloud-fan @dbatomic Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
#44316 replace current time/date prior to evaluating inline table expressions.
This PR propose to simplify the code for
ResolveInlineTablesand letResolveInlineTablesSuiteapply the ruleResolveInlineTables.Why are the changes needed?
Simplify the code for
ResolveInlineTablesandResolveInlineTablesSuite.Does this PR introduce any user-facing change?
'No'.
How was this patch tested?
Test cases updated.
GA tests.
Was this patch authored or co-authored using generative AI tooling?
'No'.