[SPARK-46472][PYTHON][DOCS] Refine docstring of array_prepend/array_append/array_insert
#44436
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
commented
Dec 21, 2023
.github/workflows/build_and_test.yml
Outdated
| SKIP_PACKAGING: true | ||
| METASPACE_SIZE: 1g | ||
| BRANCH: ${{ inputs.branch }} | ||
| SPARK_ANSI_SQL_MODE: true |
Contributor
Author
There was a problem hiding this comment.
Check ansi is true , will revert this file after the test passes.
zhengruifeng
approved these changes
Dec 21, 2023
Contributor
zhengruifeng
left a comment
zhengruifeng
left a comment
There was a problem hiding this comment.
thanks for working on this
LuciferYang
commented
Dec 21, 2023
| >>> df = spark.createDataFrame([(['a', 'b', 'c'],)], ['data']) | ||
| >>> df.select(sf.array_insert(df.data, 2, sf.lit(None).cast(StringType())) | ||
| ... .alias("result")).show() | ||
| +---------------+ |
Contributor
Author
There was a problem hiding this comment.
It seems that the headers of the results from the connect and sql tests are inconsistent, try giving it an alias.
HyukjinKwon
approved these changes
Dec 22, 2023
Contributor
Author
|
Merged into master for Spark 4.0. Thanks @HyukjinKwon @zhengruifeng |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This pr refine docstring of
array_prepend/array_append/array_insertand add some new examples.Why are the changes needed?
To improve PySpark documentation
Does this PR introduce any user-facing change?
No
How was this patch tested?
Pass Github Actions
Was this patch authored or co-authored using generative AI tooling?
No