Skip to content

[SPARK-46453][CONNECT] Throw exception from internalError() in SessionHolder #44400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MaxGekk wants to merge 2 commits into from
Closed

[SPARK-46453][CONNECT] Throw exception from internalError() in SessionHolder #44400

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03e5be8
Throw internal exception
MaxGekk Dec 18, 2023
7d65f05
Trigger build
MaxGekk Dec 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...or/connect/server/src/main/scala/org/apache/spark/sql/connect/service/SessionHolder.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ case class SessionHolder(userId: String, sessionId: String, session: SparkSessio
*/
private[connect] def cacheDataFrameById(dfId: String, df: DataFrame): Unit = {
if (dataFrameCache.putIfAbsent(dfId, df) != null) {
SparkException.internalError(s"A dataframe is already associated with id $dfId")
throw SparkException.internalError(s"A dataframe is already associated with id $dfId")
}
}

Expand All @@ -331,7 +331,7 @@ case class SessionHolder(userId: String, sessionId: String, session: SparkSessio
*/
private[connect] def cacheListenerById(id: String, listener: StreamingQueryListener): Unit = {
if (listenerCache.putIfAbsent(id, listener) != null) {
SparkException.internalError(s"A listener is already associated with id $id")
throw SparkException.internalError(s"A listener is already associated with id $id")
}
}

Expand Down