[SPARK-43299][FOLLOWUP][CONNECT][SS] Followup on StreamingQueryExceptions #44306
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@MaxGekk @HyukjinKwon Tagging people that I know who have context : ) |
Member
|
Looks good but I think it'd be great if this can be signed off by @MaxGekk |
Contributor
Author
|
Use empty string as default for test failures |
Contributor
Author
|
@MaxGekk Hi Max can I get another pass? Thank you! |
heyihong
approved these changes
Jan 2, 2024
Contributor
heyihong
left a comment
heyihong
left a comment
There was a problem hiding this comment.
LGTM with one minor comment
...ect/client/jvm/src/test/scala/org/apache/spark/sql/streaming/ClientStreamingQuerySuite.scala
Outdated
Show resolved
Hide resolved
HyukjinKwon
approved these changes
Jan 3, 2024
Member
|
Merged to master. |
MaxGekk
reviewed
Sep 8, 2024
Comment on lines
+333
to
+335
| "queryDebugString" -> toDebugString(includeLogicalPlan = isInitialized), | ||
| "startOffset" -> committedOffsets.toOffsetSeq(sources, offsetSeqMetadata).toString, | ||
| "endOffset" -> availableOffsets.toOffsetSeq(sources, offsetSeqMetadata).toString |
Member
There was a problem hiding this comment.
When you pass additional parameters, you should add placeholders for them in the error formats in error-conditions.json otherwise they are useless. Found them in the PR: #48026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Follow up on streaming query exception in Scala connect client.
StreamingQueryExceptionby adding thequeryDebugString,startOffsetandendOffsettomessageParameters, this enables us to reconstruct the exception with these fields in client side.Why are the changes needed?
Necessary build ups for spark connect.
Does this PR introduce any user-facing change?
No
How was this patch tested?
New Unit test
Was this patch authored or co-authored using generative AI tooling?
No