Skip to content

Conversation

@itholic
Copy link
Contributor

@itholic itholic commented Dec 7, 2023

What changes were proposed in this pull request?

This PR proposes to re-enable the read_excel tests

Why are the changes needed?

To improve the test coverage

Does this PR introduce any user-facing change?

No, it's test-only.

How was this patch tested?

Enabled the skipped tests and manually run

Was this patch authored or co-authored using generative AI tooling?

No.

@itholic
Copy link
Contributor Author

itholic commented Dec 7, 2023

Let me wait for CI running since it was failed with unknown reason only in GitHub Actions before. See #37671 (comment) for detail.

@itholic
Copy link
Contributor Author

itholic commented Dec 8, 2023

Yeah, seems like this still doesn't work on GitHub CI. It's wired but let me close PR for now since I couldn't catch any clue for this failure.

@itholic itholic closed this Dec 8, 2023
@itholic itholic deleted the test_read_excel branch January 1, 2024 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant