Skip to content

[SPARK-46305][BUILD][SS] Remove Zookeeper 3.5.7 test dependency from the streaming-kafka-0-10 and sql-kafka-0-10 modules #44230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LuciferYang wants to merge 2 commits into from
Closed

[SPARK-46305][BUILD][SS] Remove Zookeeper 3.5.7 test dependency from the streaming-kafka-0-10 and sql-kafka-0-10 modules #44230

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8a47d6
init
LuciferYang Dec 7, 2023
17b4ffb
Merge branch 'apache:master' into kafka-zk
LuciferYang Dec 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions connector/kafka-0-10-sql/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,11 +122,9 @@
<groupId>org.apache.hadoop</groupId>
<artifactId>hadoop-minikdc</artifactId>
</dependency>
<!-- Kafka embedded server uses Zookeeper 3.5.7 API -->

@LuciferYang LuciferYang Dec 7, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When this configuration was added in #28235, Spark defaulted to using Zookeeper 3.4.14.

spark/pom.xml

Line 125 in 7f47570

<zookeeper.version>3.4.14</zookeeper.version>

Currently, Spark has upgraded the Zookeeper version to 3.9.1. Let's see if streaming-kafka-0-10 and sql-kafka-0-10 can also successfully test with 3.9.1.

@LuciferYang LuciferYang Dec 7, 2023

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @dongjoon-hyun

Currently, Spark uses Kafka 3.4.1, and its embedded server uses Zookeeper 3.6.4. If we wish to continue using a special version of Zookeeper in these two modules, please let me know.

<dependency>
<groupId>org.apache.zookeeper</groupId>
<artifactId>zookeeper</artifactId>
<version>3.5.7</version>
<scope>test</scope>
</dependency>
<dependency>
Expand Down
2 changes: 0 additions & 2 deletions connector/kafka-0-10/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,9 @@
</exclusion>
</exclusions>
</dependency>
<!-- Kafka embedded server uses Zookeeper 3.5.7 API -->
<dependency>
<groupId>org.apache.zookeeper</groupId>
<artifactId>zookeeper</artifactId>
<version>3.5.7</version>
<scope>test</scope>
</dependency>
<dependency>
Expand Down