Skip to content

Conversation

@nastra
Copy link
Contributor

@nastra nastra commented Nov 22, 2023

What changes were proposed in this pull request?

Analyzer improvement that allows providing addtional rules for the Substitution batch

Why are the changes needed?

Required for DataSourceV2 view support.

Does this PR introduce any user-facing change?

No

How was this patch tested?

N/A

Was this patch authored or co-authored using generative AI tooling?

N/A

@github-actions github-actions bot added the SQL label Nov 22, 2023
@nastra
Copy link
Contributor Author

nastra commented Nov 22, 2023

/cc @jzhuge @aokolnychyi @holdenk

@jzhuge
Copy link
Member

jzhuge commented Dec 4, 2023

We might want to hold off this PR a bit. see #39796 (comment)

@jzhuge
Copy link
Member

jzhuge commented Dec 4, 2023

If this is approved, add SparkSessionExtensions.injectSubstitutionRule in a follow-up?

@nastra
Copy link
Contributor Author

nastra commented Dec 12, 2023

@jzhuge I think we need this PR independently from #39796 (comment) for Iceberg to have a way to hook into the substitution batch.

@holdenk / @cloud-fan could you review this one please?

@github-actions
Copy link

We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!

@github-actions github-actions bot added the Stale label Mar 22, 2024
@github-actions github-actions bot closed this Mar 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants