[SPARK-45378][CORE] Add convertToNettyForSsl to ManagedBuffer #43166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hasnain-db
changed the title
Contributor
Author
|
cc: @mridulm @JoshRosen this is now ready to review and has all green tests on CI |
Contributor
|
QQ: If/when there is more widespread adoption of |
Contributor
Author
|
@mridulm once it's widely adopted and supported in Netty + netty-tcnative, we can remove these APIs and potentially just use |
Contributor
|
Sounds good, can you add a comment to that effect in the |
hasnain-db
force-pushed
the
spark-tls-buffers
branch
from
f22ae2e to
0fd3bee
Compare
mridulm
approved these changes
Oct 2, 2023
Contributor
mridulm
left a comment
mridulm
left a comment
There was a problem hiding this comment.
Pending CI
+CC @JoshRosen
JoshRosen
approved these changes
Oct 2, 2023
Contributor
Author
|
CI is also finally green here |
Contributor
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
As the title suggests. In addition to that API, add a config to the
TransportConfto configure the default block size if desired.Why are the changes needed?
Netty's SSL support does not support zero-copy transfers. In order to support SSL using Netty we need to add another API to the
ManagedBufferwhich lets buffers return a different data type.Does this PR introduce any user-facing change?
No
How was this patch tested?
CI. This will have tests added later - it's tested as part of #42685 from which this is split out.
Was this patch authored or co-authored using generative AI tooling?
No