Skip to content

[SPARK-45301][BUILD] Remove org.scala-lang scala-library added for JDK 11 workaround #43086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
HyukjinKwon wants to merge 1 commit into from
Closed

[SPARK-45301][BUILD] Remove org.scala-lang scala-library added for JDK 11 workaround #43086

HyukjinKwon wants to merge 1 commit into from

Conversation

@HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Sep 25, 2023

What changes were proposed in this pull request?

This PR removes the legacy workaround for JDK 11 added at SPARK-28932

Why are the changes needed?

To remove legacy workaround. With JDK 17, now it seems working.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

As described in #25800

./build/mvn clean install -pl common/network-common -DskipTests
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  48.139 s
[INFO] Finished at: 2023-09-25T12:27:43+09:00
[INFO] ------------------------------------------------------------------------

Was this patch authored or co-authored using generative AI tooling?

No.

@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented Sep 25, 2023

cc @dongjoon-hyun

LuciferYang
LuciferYang approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@LuciferYang LuciferYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM

@HyukjinKwon HyukjinKwon changed the title [SPARK-28932][BUILD] Remove org.scala-lang scala-library added for JDK 11 workaround [SPARK-45301][BUILD] Remove org.scala-lang scala-library added for JDK 11 workaround Sep 25, 2023
dongjoon-hyun
dongjoon-hyun approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Merged to master.

@HyukjinKwon HyukjinKwon deleted the SPARK-45301 branch January 15, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LuciferYang LuciferYang LuciferYang approved these changes

@dongjoon-hyun dongjoon-hyun dongjoon-hyun approved these changes

Assignees

No one assigned

Labels

BUILD CORE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@HyukjinKwon @LuciferYang @dongjoon-hyun