[SPARK-45204][CONNECT] Extend CommandPlugins to be trackable #42984
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
#43311 solves this problem without the need to introduce a new interface. |
hvanhovell
pushed a commit
that referenced
this pull request
Oct 11, 2023
### What changes were proposed in this pull request? This PR adds an optional `ExecuteHolder` to `SparkConnectPlanner`. This allows plugins to access the `ExecuteHolder` to for example create a `QueryPlanningTracker` without the need to create a new `CommandPlugin` interface like proposed in #42984. ### Why are the changes needed? There is currently no way to track queries executed by a CommandPlugin. For this, the plugin needs access to the `ExecuteHolder`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? Adjusted existing tests. ### Was this patch authored or co-authored using generative AI tooling? No. Closes #43311 from dillitz/plugin-new-approach. Authored-by: Robert Dillitz <[email protected]> Signed-off-by: Herman van Hovell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adding a
CommandPluginWithQueryPlanningTrackerinterface which extends the already existingCommandPlugininterface with aprocess()method that one can pass aQueryPlanningTrackerto.Why are the changes needed?
There is currently no way to track queries executed by a
CommandPlugin.Does this PR introduce any user-facing change?
Users now can also write trackable plugins by implementing the
CommandPluginWithQueryPlanningTracker. Since this extends theCommandPlugininterface such plugins are also backward-compatible to older versions of spark only knowing theCommandPlugininterface.How was this patch tested?
Test added.
Was this patch authored or co-authored using generative AI tooling?
No